Skip to content

Potential naming conflict released in V23 #533

Description

@Raibaz

V23 included a new Metrics gRPC message in the GenerateBenchmarksMetricsResponse message: https://github.com/googleapis/googleapis/blob/master/google/ads/googleads/v23/services/benchmarks_service.proto#L351

This can potentially cause a naming clash with the Metrics message that contains generic reporting metrics.

In some client libraries this wasn't an issue because the messages live in different namespaces, but I wanted to give you a heads up about this potential issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions