Google Ads v25.1 - #141
Open
Lewis-Clayton wants to merge 13 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines, CI matrix 22.x and 24.x)init.shnow removes the previous API version's directories (by explicit path) beforenpm install, so only one version's protos are compiled:compileProtosspreads every proto-list entry into a single call, and the v24 and v25 lists together (about 199,000 entries) exceed V8's argument limit on Node 22 and 24. It also replaces the rootbuild/on copy instead of merging into it.@grpc/grpc-js1.14.4 andprotobufjs7.6.6 resolve, closing three advisories; rootnpm auditis cleanlru-cachedependencynpm auditgoes from 16 advisories to 0tests/esm.mjs) alongside the CommonJS proto testsedrules do not yet convertTest plan
yarn testpasses on Node 22.23 and 24.1925.1.0-beta.0under thebetadist-tag and consumed by google-ads-api 25.1.0-beta.025.1.0-beta.1under thebetadist-tag for google-ads-api 25.1.0-beta.1