Skip to content

Google Ads v25.1 - #141

Open
Lewis-Clayton wants to merge 13 commits into
masterfrom
google-ads-v25
Open

Google Ads v25.1#141
Lewis-Clayton wants to merge 13 commits into
masterfrom
google-ads-v25

Conversation

@Lewis-Clayton

@Lewis-Clayton Lewis-Clayton commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade from Google Ads API v24.1 to v25.1
  • Regenerate proto definitions, TypeScript clients and samples for v25; remove v24
  • Move the generator stack to gapic-tools 2 and google-gax 6; Node.js 22 or newer is now required (engines, CI matrix 22.x and 24.x)
  • init.sh now removes the previous API version's directories (by explicit path) before npm install, so only one version's protos are compiled: compileProtos spreads every proto-list entry into a single call, and the v24 and v25 lists together (about 199,000 entries) exceed V8's argument limit on Node 22 and 24. It also replaces the root build/ on copy instead of merging into it.
  • Root lockfiles regenerated so @grpc/grpc-js 1.14.4 and protobufjs 7.6.6 resolve, closing three advisories; root npm audit is clean
  • Drop the unused lru-cache dependency
  • The Dockerfile strips the generated package's test and docs tooling (mocha, sinon, c8, jsdoc, pack-n-play) and inlines gts's compiler options into its tsconfig, so the sub-package install needs only gapic-tools, typescript and @types/node: 173 packages instead of 598, and its npm audit goes from 16 advisories to 0
  • Add an ESM smoke test (tests/esm.mjs) alongside the CommonJS proto test
  • README: Node floor, and an upgrade-procedure check for request parameters the Dockerfile's sed rules do not yet convert
  • Bump package version to 25.1.0-beta.1 for testing (beta.0 was published before the review fixes)

Test plan

  • yarn test passes on Node 22.23 and 24.19
  • Published 25.1.0-beta.0 under the beta dist-tag and consumed by google-ads-api 25.1.0-beta.0
  • Publish 25.1.0-beta.1 under the beta dist-tag for google-ads-api 25.1.0-beta.1
  • Update version to 25.1.0 after review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T12:01:10.534264Z 49ded56 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant