Remove legacy Hardhat contract tests - #2982
Open
clement-ux wants to merge 5 commits into
Open
Conversation
clement-ux
requested review from
naddison36,
shahthepro and
sparrowDom
as code owners
August 25, 2026 13:07
This was referenced Aug 25, 2026
sparrowDom
reviewed
Aug 27, 2026
sparrowDom
left a comment
sparrowDom
left a comment
Member
There was a problem hiding this comment.
Great job, a couple of comments inline.
Also we might want to fix the tasks/smokeTest.js. Those read from the /deploy folder. I know it was already broken before, still this looks like a good time to address it
| @@ -1,70 +0,0 @@ | |||
| const { expect } = require("chai"); | |||
Member
There was a problem hiding this comment.
THis file unit tests the Talos tasks/crossChain.js It should not be removed. Maybe it can be moved to: tasks/test/
| @@ -4,33 +4,6 @@ | |||
|
|
|||
| The unit tests here use `MockBeaconProofs` which auto-passes all proof verification. This covers the strategy's state machine logic thoroughly but does **not** exercise the real `BeaconChainProofs` library. | |||
|
|
|||
| ### Hardhat tests not yet ported (candidates for fork tests) | |||
Member
There was a problem hiding this comment.
I think these tests were not yet ported to Foundry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Foundry is already the tool we use to test smart contracts. The repository still contained the old Hardhat contract test suite, so we had two test systems even though only one was meant to be the source of truth.
This PR removes that retired Hardhat test layer. It does not change the contracts or replace the tests again; the contract coverage already lives in Forge.
What changes
test/to where they actually belong:tasks/test/abi/hardhat/What stays
Hardhat is still present for operational tasks and, at this point in the stack, the historical deployment and ABI tooling. Those are handled separately in the follow-up PRs.
Stack
This is the first PR in the cleanup:
Validation
forge build contracts/ --force -j 1pnpm run test:tasks: 20 passingpnpm run test:scripts: 61 passingpnpm run test:layouts: 11 passingThe full all-at-once Forge build exceeded the 8 GB local runner limit; the production contracts and affected test subtrees were therefore validated separately.