Added lastVerifiedBalanceTimestamp to CompoundingStakingStrategy - #2987
Merged
Conversation
naddison36
requested review from
clement-ux,
shahthepro and
sparrowDom
as code owners
August 26, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
lastVerifiedBalanceTimestamptoCompoundingStakingStrategyso integrations can determine when beacon-chain balance data was last successfully verified.The value records the timestamp captured by
snapBalances(), not the later transaction timestamp ofverifyBalances().Changes
uint64 lastVerifiedBalanceTimestampstorage variable.verifyBalances().snapBalances()is called without a successful verification.verifyBalances()reverts.ICompoundingStakingStrategy.Existing deployments will return
0until their first successful balance verification after upgrading. No migration or backfill is required.Storage layout
The new variable consumes one reserved storage slot:
lastVerifiedBalanceTimestampis appended at slot 61.__gapis reduced from 40 to 39 slots.Tests
Added unit coverage confirming:
snapBalances()alone does not update it.snappedBalance.timestampdoes not clear the last verified timestamp.Verification performed:
make build-contractspnpm test:layouts: 11 passedgit diff --checkCode Change Checklist