fix(test): widen Windows cleanup retry window in citation-rule-self-heal - #205
Merged
Conversation
…lf-heal Failed on windows-latest in PR #203's CI, twice, in the same run, both Node 22 and Node 24 legs — always the same afterEach rmSync, always ENOTEMPTY: the temp dir's handle from the child process runHook() spawns had not been released by the OS yet. This repo's usual maxRetries: 5, retryDelay: 100 (500ms worst case) was not enough on a loaded runner; 10/200ms (2s worst case) only costs time on the runs that are already retrying. Scoped to this one file, not the ~106 other test files using the same 5/100 literal: this is the only one with observed CI failures.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
citation-rule-self-heal.test.ts'safterEachfailed onwindows-latestwithENOTEMPTYonrmSync, twice in the same CI run (PR fix: close the remaining 22 findings from tonight's full-codebase review ledger #203, both Node 22 and Node 24 legs) — the temp dir's OS-level handle from the child processrunHook()spawns had not been released yet when cleanup ran.maxRetries: 5, retryDelay: 100(500ms worst case) was not always enough under CI load. Widened to10/200(2s worst case) for this file only — that cost is paid only on the runs that are already retrying.5/100literal: this is the only file with observed CI failures, so the fix is scoped to it rather than applied speculatively everywhere.Test plan
npx vitest run tests/hooks/citation-rule-self-heal.test.ts— 6 passed locally (macOS)