DEV: prevent project saves from reopening closed vacancies - #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Причина
Обычный
Project.save()для опубликованного проекта повторно активировал все его вакансии черезprojects.signals.update_vacancy. МассовыйQuerySet.update()также оставлялdatetime_closedнесогласованным.Изменения
Project.draftфиксируется вpre_save;draft=False -> Trueилиdraft=True -> False;is_active=False,datetime_closedиdatetime_updated;is_active=True,datetime_closed=Noneиdatetime_updated;is_active;Проверки
select_for_update=True: passedmanage.py check --tag models: passedmakemigrations --check --dry-run --skip-checks: no changes detectedgit diff --check: passedЛокально database tests не стартовали из-за отсутствующего PostgreSQL на
localhost:5432, а полныйmanage.py check— из-за отсутствующей системной библиотеки WeasyPrintgobject-2.0-0; обе проверки успешно выполнены в PostgreSQL CI.Scope
Миграции, frontend, Docker, workflows/deploy, catalog #715 и response lifecycle #712 не изменялись.