Repository navigation
Fix/phase detection ema - #68
Merged
Merged
Conversation
…#1) 7 tasks, build-safe ordering: EMA module (TDD) -> rewire HMM -> re-enable config -> replace pinning test -> delete broken SG + fix extended test -> rep-count hard checkpoint (tune alpha if needed) -> tracker to green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ving) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace RealTimeSavitzkyGolay with EmaSmoother (alpha derived from windowSize via alphaFromWindow) in constructor and updateConfig reconstruction site. savitzkyGolay.ts is intentionally left in place for removal in a later task. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removes savitzkyGolay.ts (broken coefficient math, war-room #1) and the SG-specific block + import from the extended phaseDetection test. HMM smoothing now runs through EmaSmoother. No references remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…olay Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
War-room #1 → 🟢. Replace the mathematically-broken Savitzky-Golay smoother with
a correct EMA and re-enable smoothing.
EmaSmoother(src/lib/phaseDetection/ema.ts): seed-first EMA,α = 2/(windowSize+1) ≈ 0.33; constant input round-trips exactly, output stays
in [0,1] (HMM observation means stay valid).
EmaSmoother(wasRealTimeSavitzkyGolay).validatorIntegration.tsconfig defaults.savitzkyGolay.ts(broken coefficient math, −376 lines).sgDefaultDisabled.test.ts→emaSmoothing.test.ts(round-trip correctness instead of bug-existence).
Test Plan
npm run test90/90 · lint clean · build green