fix(soc-framework-nist-ir): repoint MTTI at a verdict anchor that exists - #1172
Merged
Merged
Conversation
MTTI returned null on every case. Two defects, one query: - the verdict anchor was event_type = "analysis_complete", which is never written to xsiam_socfw_ir_execution_raw. Same root cause as the MTTD fix in #1169. Now anchored on phase = Assessment, so it is producer-agnostic. - the start anchor counted only commands in phase Analysis, which is 14 rows across 5 cases. Investigation commands are emitted under Enrichment. The anchor now spans Analysis and Enrichment. Measured on a reference tenant: 0 cases before, 1,843 cases at 1.29 min after. Against the 58s baseline that is the same order of magnitude, which is the sanity check the notes call for. The max-based structure was already correct and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTTI returned null on every case. Two defects in one query.
The verdict anchor did not exist. It filtered
event_type = "analysis_complete", which is never written toxsiam_socfw_ir_execution_raw— the same root cause as the MTTD fix in #1169. Now anchored onphase = Assessment, which makes it producer-agnostic like MTTD.The start anchor was too narrow. It counted only commands in phase
Analysis— 14 rows across 5 cases. Investigation commands are emitted underEnrichment. The anchor now spans both.Against the 58s baseline that is the same order of magnitude, which is the sanity check the notes call for.
The max-based structure — last investigation command rather than first — was already correct and is unchanged.
Verification
check_contributionincluding the upload step, green. Both candidate start anchors measured on a reference tenant before choosing.