fix(soc-framework-nist-ir): match the ingestion widget header to its title - #1175
Merged
Merged
Conversation
…title The 23 Sep rename off the 'lag' framing updated the viewOptions header and left the phrase's view clause carrying the old text, so the two disagreed: viewOptions header : "Ingestion Time by Source (Avg Minutes)" phrase header : "Alert Ingestion Lag by Source (Avg Minutes)" The tile caption still read 'Alert Ingestion Lag', which is the framing the rename existed to remove, and a header mismatch is a candidate cause for a widget refusing to render. Affects the Value Metrics pair. Value Driver's ingestion widgets carry no header in their phrase and were never mismatched. Verified by comparing both header values programmatically across every widget in the pack rather than by eye - reading them by eye is how this was missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 23 Sep rename off the 'lag' framing (#1169) updated the
viewOptionsheader and left the phrase's| viewclause carrying the old text, so the two disagreed:The tile caption therefore still read Alert Ingestion Lag — the exact framing the rename existed to remove — and a header mismatch is a candidate cause for a widget refusing to render.
Affects the Value Metrics pair. Value Driver's ingestion widgets carry no
headerin their phrase and were never mismatched, so this is one widget in two files rather than the three I originally claimed.Verified by comparing both header values programmatically across every widget in the pack. Reading them by eye is how the mismatch was introduced and then missed.
check_contributionincluding the upload step, green.