Replace TrialMetadata table with a generic Settings key/value table - #5707
Open
johnsimons wants to merge 1 commit into
Open
Replace TrialMetadata table with a generic Settings key/value table#5707johnsimons wants to merge 1 commit into
johnsimons wants to merge 1 commit into
Conversation
TrialMetadata was a one row settings table. The licensing data store needs the same shape for four more singleton values, so it is now a generic Settings(Key, Value) table holding JSON documents, with GetSetting and StoreSetting helpers on the DbContext.
johnsimons
force-pushed
the
john/generic_settings
branch
from
August 7, 2026 01:26
18714b7 to
5a45e25
Compare
rbev
approved these changes
Aug 7, 2026
rbev
left a comment
rbev
left a comment
Contributor
There was a problem hiding this comment.
Looks good
My only suggestion is that it might be worth writing the type name to a column for debugging/admin purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the single row
TrialMetadatatable with a genericSettings(Key, Value)table that stores JSON documents, keyed by entries inSettingKeys.This is groundwork for the EF licensing data store, which needs to persist
BrokerMetadata,AuditServiceMetadata,ReportMasksandLicensedEndpointDetails: all singleton documents in RavenDB, all read and written whole and never queried by their contents. Rather than six near identical tables, they share one.TrialLicenseDataProvidernow goes throughGetSetting/StoreSetting, with writes using the existingUpsertAsyncextension. Migrations for both providers dropTrialMetadataand createSettings. Nothing EF related has shipped, so no data is copied.