FIX: Fix PyCalphad Model.ast being defined in moles of formula units - #295
Merged
bocklund merged 3 commits intoSep 28, 2026
Merged
Conversation
pycalphad Model contributions (Model.ast and Model.models) are now built per mole of formula units, with GM = ast / _site_ratio_normalization. Remove the mole-atoms to mole-formula conversions that would now double count the normalization, subtract per-formula model attributes (e.g. V0) after converting data to per-formula units, and normalize V0 where molar values are needed. Convert the hard-coded per-mole-atoms GM fixture in the response vector test at hot-patch time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pycalphad/pycalphad#724 for details