Skip to content

Fix RemoteSupport systemd state directory bootstrap #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarotsSugarpie merged 1 commit into from
Sep 9, 2026
Merged

Fix RemoteSupport systemd state directory bootstrap #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/remote-support-v1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,16 @@ jobs:
- name: Systemd activation links
run: |
set -Eeuo pipefail
test -f etc/systemd/system/pincabos-remote-support.service
unit='etc/systemd/system/pincabos-remote-support.service'
test -f "$unit"
test -L etc/systemd/system/multi-user.target.wants/pincabos-remote-support.service
test -L etc/systemd/system/pincabos-webapp.service.wants/pincabos-remote-support.service
test "$(readlink etc/systemd/system/multi-user.target.wants/pincabos-remote-support.service)" = '../pincabos-remote-support.service'
test "$(readlink etc/systemd/system/pincabos-webapp.service.wants/pincabos-remote-support.service)" = '../pincabos-remote-support.service'
grep -Fq 'ConditionPathExists=/var/lib/pincabos-link/device.json' etc/systemd/system/pincabos-remote-support.service
grep -Fq 'ConditionPathExists=/var/lib/pincabos-link/device.json' "$unit"
grep -Fq 'StateDirectory=pincabos-remote-support' "$unit"
grep -Fq 'StateDirectoryMode=0700' "$unit"
! grep -Fq 'ReadWritePaths=/var/lib/pincabos-remote-support' "$unit"

- name: Update V4 scope
run: |
Expand All @@ -66,7 +70,7 @@ jobs:
for rel in paths:
allowed = bool(mod.allowed(rel))
build = bool(mod.allowed_for_build(rel))
print(('GO [OK]' if allowed and build else 'NOGO [!!]'), rel, 'allowed=', allowed, 'build=', build)
print(('GO [OK]' if allowed and build else 'NOGO [FAIL]'), rel, 'allowed=', allowed, 'build=', build)
if not (allowed and build):
failed.append(rel)
if failed:
Expand Down
3 changes: 2 additions & 1 deletion etc/systemd/system/pincabos-remote-support.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ NoNewPrivileges=false
PrivateTmp=true
ProtectSystem=full
ProtectHome=false
ReadWritePaths=/var/lib/pincabos-remote-support /home/pinball/.ssh
StateDirectory=pincabos-remote-support
StateDirectoryMode=0700

[Install]
WantedBy=multi-user.target
Loading