Skip to content

fix: improve Player layout in compact multi-window mode - #2865

Open
pixel-daemon-bot wants to merge 1 commit into
PixelPlayerHQ:masterfrom
pixel-daemon-bot:fix/2632-compact-player-layout
Open

pixel-daemon-bot wants to merge 1 commit into
PixelPlayerHQ:masterfrom
pixel-daemon-bot:fix/2632-compact-player-layout

Conversation

@pixel-daemon-bot

Copy link
Copy Markdown

Summary

Fixes #2632.

The Player layout could show a large empty area when PixelPlayer was used in Samsung Split Screen / Pop-up View.

The fix makes the Player content react to the actual Compose window constraints in compact-height layouts.

Changes

  • use the actual available Compose height when deciding compact Player layout behavior;
  • avoid excessive vertical distribution with SpaceAround / SpaceEvenly in compact windows;
  • constrain the album carousel to the available height;
  • allow vertical scrolling as a fallback when the compact window cannot fit the existing content;
  • keep the existing large-window portrait and landscape layout unchanged;
  • add JVM regression tests for compact-layout decisions and carousel height constraints.

Validation

Passed locally:

  • :app:compileDebugKotlin
  • :app:testDebugUnitTest --tests *PlayerCompactLayoutTest* --tests *PlayerBottomAnchoringTest* — 13/13 tests passed
  • :app:assembleDebug
  • git diff --check

Testing limitation

The reported issue was reproduced by the original reporter on a Samsung Galaxy S25 with One UI 8.5 / Android 16.

We do not have a Samsung device reproducing that exact environment, so the fix has not been physically verified on One UI 8.5 Split Screen / Pop-up View.

The implementation is intentionally device-agnostic and does not add Samsung-specific code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: weird UI issue with Split screen/Pop-up view on Samsung phones

1 participant