fix: improve Player layout in compact multi-window mode - #2865
Open
pixel-daemon-bot wants to merge 1 commit into
Open
pixel-daemon-bot wants to merge 1 commit into
pixel-daemon-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2632.
The Player layout could show a large empty area when PixelPlayer was used in Samsung Split Screen / Pop-up View.
The fix makes the Player content react to the actual Compose window constraints in compact-height layouts.
Changes
SpaceAround/SpaceEvenlyin compact windows;Validation
Passed locally:
:app:compileDebugKotlin:app:testDebugUnitTest --tests *PlayerCompactLayoutTest* --tests *PlayerBottomAnchoringTest*— 13/13 tests passed:app:assembleDebuggit diff --checkTesting limitation
The reported issue was reproduced by the original reporter on a Samsung Galaxy S25 with One UI 8.5 / Android 16.
We do not have a Samsung device reproducing that exact environment, so the fix has not been physically verified on One UI 8.5 Split Screen / Pop-up View.
The implementation is intentionally device-agnostic and does not add Samsung-specific code.