fix: localize backup section labels - #2868
Open
pixel-daemon-bot wants to merge 1 commit into
Open
pixel-daemon-bot wants to merge 1 commit into
pixel-daemon-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes BackupSection labels and descriptions localizable by moving their presentation text from hardcoded strings in the data model to Android string resources.
Changes
@StringRes labelResanddescriptionRestoBackupSection;key,iconRes, andsinceVersionunchanged;BackupSectionTestfor the current 12-section model and validate resource parity.Architecture
The stable
BackupSection.keyremains the persistence/serialization identity.Presentation text is now represented by
labelResanddescriptionRes, following existing PixelPlayer patterns for resource IDs in models.The older
label/descriptionString fields remain temporarily as a compatibility bridge because Backup/Restore progress and validation localization are intentionally deferred to subsequent changes.No Android
Contextwas introduced into the data layer.Validation
Passed locally:
BackupSectionTest— 12/12:app:processDebugResources:app:compileDebugKotlingit diff --checkScope
This PR intentionally covers only
BackupSectionpresentation localization.Backup/Restore progress events, validation error messages, and the broader localization system are outside this PR.
Do not claim that Backup/Restore is fully localized.