Require explicit RuleSpec roots in the Axiom adapter - #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AxiomEnginecaller to provide a non-empty explicit sequence of canonical RuleSpec roots.rulespec-zzlayout and update all in-repo callers, docs, and changelog.Why
The current Axiom runtime requires
CompiledDenseProgram.from_file(..., rulespec_roots=..., entity=...). Microcosm still called the retired implicit-root signature, so the Belgian pilot in PolicyEngine/policyengine.py#448 could not execute against the current runtime. Explicit roots also make the filesystem authority boundary reproducible and fail closed.This intentionally changes the adapter constructor. External callers must pass their canonical checkout, for example
rulespec_roots=(rulespec_be_root,).Verification
bb4b5684: 49 passed, 12 skippedmicrocosm-framesuite: 275 passed, 25 skippedgit diff --check: passedResidual risk is fail-safe: missing-entity discrimination currently follows Axiom's exact error text, so upstream wording drift would raise rather than silently broaden authority.