Skip to content

Belgium page: general framing across sources, and source-document links - #116

Merged
MaxGhenis merged 1 commit into
mainfrom
be-page-general-framing-links
Aug 29, 2026
Merged

Belgium page: general framing across sources, and source-document links#116
MaxGhenis merged 1 commit into
mainfrom
be-page-general-framing-links

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Follow-up to #115, on Max's review of the live page: the Belgium instance framing hardcoded "vs JRC EUROMOD-BE" even though the reform-validation registry now holds SPF Finances, Cour des comptes and PolicyEngine claims, and the official rows carried no link to their source document.

Framing (app copy only):

  • Header: "vs SPF Finances, Cour des comptes and JRC EUROMOD-BE" (UK-style source listing), eyebrow "Belgium lanes".
  • Comparison-grid empty state and headline now describe both lanes — the seven PIT-reform claims and the JRC EUROMOD-BE lane — instead of the JRC lane alone.
  • BE_REFORM_DESCRIPTION reordered to lead with the PIT-reform claims; every doctrine disclosure (self-attachments, unresolved official period basis) is unchanged and still pinned by test.

Source links (data):

  • The SPF Finances and Cour des comptes rows now carry publication.url = https://www.lachambre.be/FLWB/PDF/56/1243/56K1243004.pdf — the public Chamber copy of DOC 56 1243/004. The live bytes hash exactly to the manifest's doc56_1243_004_pdf sha-256 pin (verified 2026-08-29), so the link serves the pinned document byte-for-byte.
  • PolicyEngine rows keep an empty URL: the pinned run report has no public home, and we don't link what isn't published.
  • The app already rendered row.url when present (as on the JRC rows), so no rendering change was needed.

No values change. Local mirror green: ruff format (CI scope), double-build determinism, 280 pytest, oxlint, 18 bun tests, vite build. Copy-and-provenance-only diff, shipping on CI green per the #85 precedent (no sol round).

🤖 Generated with Claude Code

The Belgium header, empty-state and headline copy framed the whole
instance as "vs JRC EUROMOD-BE"; with SPF Finances, Cour des comptes
and PolicyEngine claims now registered, the copy names all sources,
UK-style. The two official PIT-reform rows also gain a publication
URL: the public lachambre.be copy of committee report DOC 56 1243/004,
whose live bytes hash exactly to the manifest's doc56_1243_004_pdf pin
(verified 2026-08-29). PolicyEngine rows keep an empty URL — the pinned
run report has no public home. No values change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis merged commit 52a4ab4 into main Aug 29, 2026
3 checks passed
@MaxGhenis
MaxGhenis deleted the be-page-general-framing-links branch August 29, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant