Skip to content

Fix reversed parameter value history intervals - #500

Merged
anth-volk merged 5 commits into
mainfrom
fix/499-parameter-value-intervals
Aug 27, 2026
Merged

Fix reversed parameter value history intervals#500
anth-volk merged 5 commits into
mainfrom
fix/499-parameter-value-intervals

Conversation

@anth-volk

@anth-volk anth-volk commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #499

Summary

  • return Parameter.parameter_values from oldest to newest
  • derive inclusive, non-overlapping end dates from the following effective start
  • retain Core's first effective value when duplicate starts are present
  • document the public history contract and add US, UK, consecutive-day, and reform-conversion regressions

Validation

  • uv run --frozen pytest tests/test_parameter_values.py tests/test_parametric_reforms.py tests/test_models.py tests/test_dict_reforms_on_simulation.py -q — 67 passed
  • uv run --frozen make format — passed
  • uv run --frozen make lint — passed
  • uv run --frozen mypy src/policyengine/core/parameter.py — passed
  • full installed US and UK catalog audit — zero interval violations

Full integration and dataset-backed tests were not run.

@anth-volk
anth-volk marked this pull request as ready for review August 27, 2026 11:22
@anth-volk
anth-volk merged commit 37a915d into main Aug 27, 2026
13 checks passed
@anth-volk
anth-volk deleted the fix/499-parameter-value-intervals branch August 27, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter.parameter_values derives reversed end dates from newest-first Core histories

1 participant