fix(github): point GitHub services at the renamed repo - #34
Merged
PonceGL merged 2 commits intoSep 11, 2026
Merged
Conversation
fetchPlayStoreAnnouncement() defaulted to owner=theovilardo, repo=PixelPlay — the project's name before the rename to PixelPlayerHQ/PixelPlayer. Works today only because raw.githubusercontent.com still resolves the old path (verified: both URLs return identical content, same etag) — a silent dependency on nobody claiming the old name. Points the defaults at the real repo. Single caller (MainActivity.kt:758) uses no arguments, so this is the only thing that needed to change there. Self-review (code-review skill) found the identical problem in the sibling GitHubContributorService.fetchContributors(), same owner/repo defaults, powering the About screen's contributor list (AboutScreen.kt:202, also called with no arguments) — not named in the original plan, but the same bug. Confirmed empirically: unlike the raw-content case, api.github.com/repos/theovilardo/PixelPlay returns an actual HTTP 301, not a silent 200 — one redirect hop this fix now removes entirely rather than leaving it to keep working by GitHub's grace. Fixed with the same one-line-per-default change. No test added in either file: this predates P.9's genericization of GitHubAnnouncementPropertiesService (fetchRawProperties, separate branch, unmerged) which is what makes that service testable without hitting real network — redoing that refactor here would duplicate P.9's own scope, and GitHubContributorService has no equivalent seam at all. Nothing to assert about a default string value without one. Baseline: 5 pre-existing failures, none new. assembleDebug succeeds.
…elPlayer code-review on PR #34 found the rename missed 4 more hardcoded URLs beyond the two services this PR already updated: - AboutScreen.kt's 'Open GitHub repo' chip - BetaInfoBottomSheet's issues/report links - ChangelogBottomSheet's changelog link - GenericOpenAiClient's OpenRouter HTTP-Referer attribution header Verified both the old and new URLs: old owner/repo now only 301s, new owner/repo resolves live (200) on both raw.githubusercontent.com and api.github.com. Left untouched on purpose: AboutScreen.kt's "theovilardo" references (the maintainer's personal GitHub account, not the repo), and README.md/CHANGELOG.md (the latter is a historical record of past PRs and shouldn't be rewritten). A fifth finding — the owner/repo pair is duplicated as string literals in 6+ places, which is exactly why the rename missed spots — was left for a follow-up: a shared GitHubRepo.OWNER/REPO constant is a real fix but a structural change beyond this diff. Verified: compiles, full JVM suite green (388 tests, same 5 pre-existing baseline failures as master, none new).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged internally first (was chore/p8-github-announcement-repo-rename on PixelPlayerHQ#2827, closed — see that PR's closing comment). Will be proposed upstream again once the downloads feature it's part of is further along.