Rewrite of the website - #167
Conversation
|
Some things that need to be done:
The CONTRIBUTING.md is on it's way. Did I miss something? |
|
@andy5995 can you review this? We also talked about this on Discord. |
|
added source urls from both |
|
@ivan-hc I will try. In my opinion, if a lot of changes are needed for a website rewrite, then it normally should be done in smaller chunks so changes can be efficiently reviewed by the maintainer. If this were my project, I'd suggest a contributor submit the first required stage in a pull request. After that is reviewed and merged, then a "stage 2" commit and PR. Why are over 3000 files getting changed in this single pull request? The site is normally generated using tools and scripts from the AM repo. If the existing site generator can't write the proposed changes, then my first thought would be a single converter script is needed in the AM repo that will implement the proposed changes to all the appimage entries. I can't think of any more feedback right now, but if I do, I'll post here. And maybe I'll be able to review more once my questions are answered. |
|
@andy5995 I completely agree. Changes like this need to be analyzed in gradual phases. @coyoteclan here are too many changes to analyze. |
This is a catalogue, it's expected. The generator script and workflow is updated. It does generate the new website. But I had to test it so I enabled the workflow and ran it. You can see individual commits. |
But there are thousands of changed files and thousands of changed lines in this commit. In cases like this, you need to eliminate all the changes that aren't required, submit changes for the script additions and changes so the maintainer (@ivan-hc ) can examine them without the extra noise. I understand you wanted to test, and that's great, but I believe @ivan-hc would need you to remove your test output/artifacts from the PR. |
okay cool. I need further testing. I will copy the generated output in apps/ and re-add the old files temporarily when i am done. after the PR is merged, we can re-add the new app files back. |
|
@andy5995 i proposed a simple syntax for defining app info on pkgforge discord: the app.html file uses json this info would then be converted to json by a script during pages deployment and served on the website this new syntax will simplify the AM about logic too because the format was pretty inconsistent previously i am currently working on this |
|
I don't see this as being desirable. It would be an extra maintenance burden for this project to have links to the Discord, donation buttons for other projects. How would that information get updated when the links change or become dead over time? @ivan-hc agree? That's from https://coyoteclan.github.io/Portable-Linux-Apps.github.io/apps/testapp.json |
That's for an example. The original contributing.md said you can add extra buttons. So I included a way to define extra buttons. The matter of links becoming dead is same as it was before. |
|
To write a markdown is simpler than compiling a json, and more customizable for common users. |
i think you didn't read my message properly. Users write this: it gets converted to json for site deployment automatically by the workflow but this info file remains intact in the repo. no json files are committed. the json files are only used on website. users write and edit the above mentioned markdown-ish format. so like i said before, we are getting both benefits now:
i updated the faq entry on how to improve app pages |
Oh, I see now. :) |
This general guide has more information about "best practices" https://www.deployhq.com/blog/the-perfect-pull-request-best-practices-for-collaborative-development |
@coyoteclan Please post the screenshots here instead of the links, then remove all the generated artifacts, update the PR. Then we will be able to review the code that changes the website infrastructure. |
How apps are defined by contributors or "dumb" apps generated by sync with AM workflow: This info file is converted to json and served on the deployed site: And the app.html page renders the json data like this: real app example, virtualbox:
|
|
thanks for the article link. i will do it now |
|
@ivan-hc i noticed now i have missing categories. you pointed it out before but i didn't pay much attention. i used the script that was present on this repo instead of the AM one. fixing it now and improving the overall logic of category and category page generation |
|
done, we are down to 71 files changed, most of them are deleted files. run by sync with AM worklfow: am2pla-site (in this repo) now does only these things:
run by pages deployment workflow: simple2json.py replaces the simple app info files in gen_cats.py generates gen_cat_pages.py generates |
|
actually, apps.json too shouldn't be tracked in git, i will move that to the website deployment |
|
done, now we're golden, sync with AM now only removes unnecessary app info files and creates dumb info and icon files |
|
there is a problem in website deployment, i am debugging it at https://github.com/Wolf-Pack-Clan/Portable-Linux-Apps.github.io |
|
okay now everything seems good |
|
@kazam0180 50,000 changed lines is still way too many changes for a PR like this. And there are merge conflicts that would have to be fixed. Have you AI agent review the PR and the comments left by @ivan-hc and me, and post what it says here. |
@andy5995 first of all i am not that stupid, i dont fully vibe code. i used AI to win time because it would take me like 3 or 4 days to get the html and css like this and AI is pretty good at UI and UX stuff. all of the comments are already addressed since #167 (comment). i cant reduce any more changes. this is the minimum possible. the conflicts are because of the deleted category pages. maybe i should re-add them 🤔 |
I didn't say you were stupid. I also use LLM to save time. |
|
what i meant by "not that stupid" was that i can and have solved the issues in the PR myself so you gonna take a look? |
|
@andy5995 should i create a new fork with the new files only? or discard commits then add new files |
|
Guys, I'd love to have a modicum of your web development skills. Unfortunately, my knowledge doesn't extend beyond BASH/SHELL and Markdown, so I can't be of much help. Sorry for the silence. |
No problem at all! |
|
@kazam0180 If this were my project, I'd say... before you fork and make any more changes, start a Discussion on the AM repo that sketches an outline of the architecture of the changes you'd like to introduce. From there, we'll see about taking things step-by-step. @ivan-hc do you agree? |
|
Yes @andy5995 , the ideas are good and it looks even better... but I feel inundated with information and strings to analyze that I wouldn't be able to decipher without the proper knowledge. |
|
alright, will do |




I have looked through it fixed the issues I found. You might want to check FAQ and Wiki page @ivan-hc