fix(flags): align presence operator semantics - #897
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-26 09:40:55 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
August 26, 2026 10:01
Contributor
|
Reviews (1): Last reviewed commit: "fix(flags): preserve fallback after inco..." | Re-trigger Greptile |
ioannisj
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
sdk-specs PR #49 defines presence operators using property-key presence and partial property context. The Python local evaluator treated a present
Nonevalue as not set and could not resolveis_not_setwhen the key was present.This change makes every present key match
is_setand not matchis_not_set, includingNoneand other falsey values. An omitted key remains inconclusive, including when a laterearly_exitcondition excludes the user by rollout, so remote fallback stays eligible.💚 How did you test it?
uv run pytest posthog/test/test_feature_flags.py -q(187 passed, 15 subtests passed)uv run ruff format --check posthog/feature_flags.py posthog/test/test_feature_flags.pyuv run ruff check posthog/feature_flags.py posthog/test/test_feature_flags.py989b7d5with no actionable findings.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent worker subagents implemented and validated the focused matcher change. The bundled autoreview tool reviewed the final committed diff against
origin/main.