feat(error-tracking): standardize exception event metadata - #898
Open
hpouillot wants to merge 3 commits into
Open
feat(error-tracking): standardize exception event metadata#898hpouillot wants to merge 3 commits into
hpouillot wants to merge 3 commits into
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-26 10:13:13 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
Prompt To Fix All With AI### Issue 1
posthog/exception_utils.py:696-698
**Repeated members are omitted**
When an exception object occupies multiple valid positions in an `ExceptionGroup` tree, the shared `seen_exception_ids` set discards every occurrence after the first, causing `$exception_list` to omit members and report incomplete group structure.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(error-tracking): preserve explicit t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+696
to
+698
| if id(exc_value) in seen_exception_ids or exception_id >= 50: | ||
| return (exception_id, []) | ||
| seen_exception_ids.add(id(exc_value)) |
Contributor
There was a problem hiding this comment.
When an exception object occupies multiple valid positions in an ExceptionGroup tree, the shared seen_exception_ids set discards every occurrence after the first, causing $exception_list to omit members and report incomplete group structure.
Knowledge Base Used: Event payload processing
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/exception_utils.py
Line: 696-698
Comment:
**Repeated members are omitted**
When an exception object occupies multiple valid positions in an `ExceptionGroup` tree, the shared `seen_exception_ids` set discards every occurrence after the first, causing `$exception_list` to omit members and report incomplete group structure.
**Knowledge Base Used:** [Event payload processing](https://app.greptile.com/posthog-org-19734/-/custom-context/knowledge-base/posthog/posthog-python/-/docs/event-payload-processing.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Contributor
Author
There was a problem hiding this comment.
This is intentional for the canonical exception graph contract: the same exception object must not be serialized more than once, including when it is referenced by multiple ExceptionGroup positions. The shared identity set also provides cycle safety. I added a regression test covering a repeated group member in 0fbbfc4.
ablaszkiewicz
approved these changes
Aug 26, 2026
marandaneto
reviewed
Aug 26, 2026
marandaneto
left a comment
marandaneto
left a comment
Member
There was a problem hiding this comment.
Automated advisory code review.
|
|
||
| is_exception_group = BaseExceptionGroup is not None and isinstance( | ||
| exc_value, BaseExceptionGroup | ||
| (_, exceptions) = _exceptions_from_error( |
Member
There was a problem hiding this comment.
blocking: Restrict group traversal to actual exception groups — Routing every exception through _exceptions_from_error now exposes ordinary exceptions to its hasattr(exc_value, "exceptions") group heuristic. A custom exception with an unrelated non-iterable exceptions attribute raises TypeError, which Client.capture_exception swallows and consequently drops the event; an iterable value instead creates phantom child exceptions. Previously, non-BaseExceptionGroup exceptions used walk_exception_chain and avoided this branch, so group-member traversal must remain restricted to actual BaseExceptionGroup instances.
Member
|
This change introduces backwards-incompatible public schema/API/contract changes: Reserved exception properties supplied through capture_exception(..., properties=...) can no longer override SDK-generated or processor-owned values. If thats intentional, thats ok, but i think its not as designed, user provided props should always win |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Standardize Python exception events with the cross-SDK metadata contract so severity, capture source, mechanism semantics, nested linkage, and reserved property ownership are predictable.
Canonical contract: https://github.com/PostHog/sdk-specs/blob/main/openspec/specs/exception-event-metadata/spec.md
💚 How did you test it?
📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with pi from the shared OpenSpec contract. Integration-only capture metadata is kept out of the public API while manual and automatic capture paths preserve their existing behavior.