Skip to content

fix(flags): align local case folding with the flags service - #902

Open
marandaneto wants to merge 4 commits into
mainfrom
fix/issue-78019-case-folding
Open

fix(flags): align local case folding with the flags service#902
marandaneto wants to merge 4 commits into
mainfrom
fix/issue-78019-case-folding

Conversation

@marandaneto

@marandaneto marandaneto commented Aug 27, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

Local feature flag evaluation returned different exact and string-operator results from the released /flags service.

This fixes PostHog/posthog#78019 against the service's current Rust matcher. A separate draft proposes simplifying the backend's unusual boolean behavior: PostHog/posthog#90694. This PR intentionally mirrors the released behavior until that proposal merges.

The evaluator now:

  • applies the backend boolean-like filter gate before normal array membership
  • preserves the backend's current empty-array and aggregate boolean-array behavior
  • serializes JSON values with compact arrays and recursively sorted object keys
  • formats representable Python floats like serde_json, including exponent thresholds and negative zero
  • treats non-finite numbers and non-JSON values as inconclusive so evaluation can fall back to /flags
  • uses full Unicode lowercase for exact and is_not
  • uses ASCII-only lowercase for contains, prefix, and suffix operators

Python preserves integer and float types after JSON parsing, but it does not preserve a number's original source spelling. Matching uses the canonical spelling produced from the parsed value, as the backend does with serde_json::Value.

💚 How did you test it?

Red-green regression coverage reproduces the released backend's boolean precedence, empty arrays, composite JSON, float spellings, final sigma, and dotted capital I.

  • uv run pytest -q - 2,285 passed, 15 skipped
  • uv run ruff check .
  • uv run ruff format --check .
  • uv run mypy --no-site-packages --config-file mypy.ini . | uv run mypy-baseline filter
  • uv run python .github/scripts/check_public_api.py
  • uv run python -W error -c 'import posthog'
  • 100,000 deterministic finite float bit patterns matched serde_json formatting in a temporary differential check
  • autoreview --mode local - no actionable findings after one accepted blocker was fixed

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

The patch changeset is .sampo/changesets/standardize-flag-case-folding.md.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Pi used the address-pr-comments, check-pr, autoreview, and karpathy-guidelines skills. The final review caught a non-finite value bypass in the boolean path, which was fixed before publication. A human must review before merge.

@marandaneto marandaneto self-assigned this Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-08-28 06:27:56 UTC
Duration: 256370ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint 517ms
Endpoint And Method.Does Not Use Legacy Endpoints 511ms
Required Headers.Has Authorization Bearer Header 510ms
Required Headers.Has Content Type Json 511ms
Required Headers.Has Posthog Sdk Info Format 510ms
Required Headers.Has Posthog Attempt Header 510ms
Required Headers.Has Posthog Request Id 510ms
Required Headers.Has Posthog Request Timestamp 511ms
Required Headers.Has User Agent 510ms
Body Format.Body Has Created At And Batch 510ms
Body Format.No Api Key In Body 510ms
Body Format.No Sent At In Body 510ms
Event Format.Event Has Required Root Fields 510ms
Event Format.Event Uuid Is Valid 511ms
Event Format.Event Timestamp Is Rfc3339 510ms
Event Format.Distinct Id Is String 511ms
Event Format.Distinct Id At Root Not Properties 510ms
Event Format.Custom Properties Preserved 511ms
Event Format.Set Properties Preserved 510ms
Event Format.Set Once Properties Preserved 510ms
Event Format.Groups Properties Preserved 510ms
Event Format.Sdk Generates Uuid If Not Provided 510ms
Event Format.Event Has Required Root Fields Batch 513ms
Event Format.Event Uuid Is Valid Batch 514ms
Event Format.Event Timestamp Is Rfc3339 Batch 514ms
Event Format.Distinct Id Is String Batch 513ms
Event Format.Distinct Id At Root Not Properties Batch 514ms
Event Format.Custom Properties Preserved Batch 514ms
Event Format.Set Properties Preserved Batch 513ms
Event Format.Set Once Properties Preserved Batch 514ms
Event Format.Groups Properties Preserved Batch 514ms
Event Format.Sdk Generates Uuid If Not Provided Batch 513ms
Batch Behavior.Multiple Events In Single Batch 518ms
Batch Behavior.Batch Envelope Smoke 515ms
Batch Behavior.Flush With No Events Sends Nothing 507ms
Batch Behavior.Flush At Triggers Batch 1010ms
Batch Behavior.Created At Reflects Batch Creation Time 511ms
Deduplication.Generates Unique Uuids 518ms
Deduplication.Different Events Same Content Different Uuids 512ms
Deduplication.Preserves Uuid On Retry 6515ms
Deduplication.Preserves Timestamp On Retry 6520ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6520ms
Deduplication.No Duplicate Events In Batch 519ms
Header Behavior On Retry.Attempt Header Starts At One 510ms
Header Behavior On Retry.Attempt Header Increments On Retry 13522ms
Header Behavior On Retry.Request Id Preserved On Retry 6515ms
Header Behavior On Retry.Different Requests Have Different Request Ids 3019ms
Header Behavior On Retry.Request Timestamp Changes On Retry 6520ms
Response Format Validation.Success Response Has Uuid Keyed Results 511ms
Response Format Validation.Success Response Has Ok For Each Event 514ms
Response Format Validation.Success No Retry After When All Ok 513ms
Response Format Validation.Success Retry After Present When Retry Events 1515ms
Response Format Validation.Success No Retry After When Drop Only 513ms
Response Format Validation.Response Echoes Request Id 510ms
Retry Behavior.Retries On 408 6515ms
Retry Behavior.Retries On 500 6520ms
Retry Behavior.Retries On 503 8519ms
Retry Behavior.Retries On 504 6516ms
Retry Behavior.Retryable Errors Have Retry After 3517ms
Retry Behavior.Respects Retry After On Retryable Error 11523ms
Retry Behavior.Does Not Retry On 400 2512ms
Retry Behavior.Does Not Retry On 401 2513ms
Retry Behavior.Does Not Retry On 402 2512ms
Retry Behavior.Does Not Retry On 413 2513ms
Retry Behavior.Does Not Retry On 415 2512ms
Retry Behavior.Non Retryable Errors Have No Retry After 2514ms
Retry Behavior.Implements Backoff 22536ms
Retry Behavior.Max Retries Respected 22536ms
Partial Batch Handling.Handles 200 Full Success 2514ms
Partial Batch Handling.Handles 200 With All Ok 3518ms
Partial Batch Handling.Does Not Retry Dropped Events 3515ms
Partial Batch Handling.Does Not Retry Limited Events 3516ms
Partial Batch Handling.Prunes Ok Events On Partial Retry 6517ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry 6518ms
Partial Batch Handling.Retries Only Retry Events From Partial 6522ms
Partial Batch Handling.Partial Retry Preserves Uuids 6522ms
Partial Batch Handling.Partial Retry Attempt Header Increments 6521ms
Partial Batch Handling.Partial Retry Request Id Preserved 6517ms
Partial Batch Handling.Respects Retry After On Partial 8522ms
Partial Batch Handling.Unknown Result Treated As Terminal 3516ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry 3517ms
Compression.Sends Gzip Content Encoding 511ms
Compression.No Content Encoding When Disabled 510ms
Compression.Compressed Body Is Decompressible 510ms
Error Handling.Does Not Retry On Unknown 4Xx 2512ms
Event Options.Cookieless Mode Override 511ms
Event Options.Disable Skew Correction Override 510ms
Event Options.Process Person Profile Override 510ms
Event Options.Product Tour Id Override 510ms
Event Options.Unset Options Omitted 510ms
Event Options.Options Override In Batch 513ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties 510ms
Geoip And Historical Migration.Historical Migration Set In Body 510ms
Geoip And Historical Migration.Historical Migration Absent By Default 511ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 11ms
Request Payload.Flags Request Uses V2 Query Param 9ms
Request Payload.Flags Request Hits Flags Path Not Decide 10ms
Request Payload.Flags Request Omits Authorization Header 9ms
Request Payload.Token In Flags Body Matches Init 10ms
Request Payload.Groups Round Trip 9ms
Request Payload.Groups Default To Empty Object 10ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 9ms
Request Payload.Disable Geoip Omitted Defaults To False 10ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 10ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 510ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 14ms
Request Lifecycle.Mock Response Value Is Returned To Caller 9ms
Retry Behavior.Retries Flags On 502 314ms
Retry Behavior.Retries Flags On 504 313ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 512ms

@marandaneto
marandaneto requested a review from a team August 27, 2026 05:47
@posthog-project-board-bot posthog-project-board-bot Bot moved this to In Progress in Feature Flags Aug 27, 2026
@marandaneto
marandaneto marked this pull request as ready for review August 27, 2026 05:51
@marandaneto
marandaneto requested a review from a team as a code owner August 27, 2026 05:51
@posthog-project-board-bot posthog-project-board-bot Bot moved this from In Progress to In Review in Feature Flags Aug 27, 2026
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
posthog/test/test_feature_flags.py:5105-5106
**Parameterize matching test cases**

The new exact-matching cases run several input tuples through manual loops, so failures identify only the enclosing test method rather than the individual case. Using the existing parameterized-test pattern would provide clearer case-level diagnostics; the same pattern applies to the new float-stringification cases.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix(flags): preserve the utils module ex..." | Re-trigger Greptile

Comment thread posthog/test/test_feature_flags.py Outdated
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Feature Flags Aug 27, 2026
@arnohillen

Copy link
Copy Markdown

compute_exact_match in posthog/feature_flags.py:543-547 (pre-existing, but inside the block this PR rewrites) has no equivalent of the service's leading boolean-coercion branch (is_truthy_or_falsy_property_value, rust/feature-flags/src/properties/property_matching.rs:212-220), so an exact filter of false or "false" against property "banana" returns False locally while the service matches, and filter [] against property true returns False locally vs true on the service.

@posthog-project-board-bot posthog-project-board-bot Bot moved this from Approved to In Review in Feature Flags Aug 28, 2026
@marandaneto

Copy link
Copy Markdown
Member Author

Addressed the current-backend parity concerns in signed commit 83e1c27. The focused regression matrix reproduced false/"banana" and []/true as local False before the fix; both now match the released backend as True. It also covers boolean-array precedence and the is_not complement. The same commit adds compact recursively sorted JSON serialization, serde-compatible formatting for representable floats, stronger final-sigma/dotted-I tests, and inconclusive fallback for non-JSON values. The full Python suite, Ruff, Mypy, public API check, import check, and autoreview pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Case folding and numeric stringification are inconsistent between SDK local evaluation and the flags service

3 participants