Remove now-redundant local installcheck: install workaround

[jnasbyupgrade]

pgxntool 2.3.0 (#31) adds this same `installcheck: install` edge directly in `pgxntool/base.mk` (fixes the check-stale-expected ordering issue this local copy in the root `Makefile` worked around since #9). Declaring it twice was harmless to Make but is now dead weight, and the local comment's "until that's fixed upstream" is stale -- it's fixed in #31.

Flagged by the automated review on #31.

Co-Authored-By: Claude noreply@anthropic.com

[github-actions]

Claude finished @jnasbyupgrade's task in 1m 13s —— View job

---

Claude's Review

• Gather context (read PR diff, related files, CLAUDE.md)
• Understand the request (code review)
• Review the change for correctness
• Post review feedback

Verdict: LGTM.

I verified the core claim in the PR description directly:

• pgxntool/base.mk:326 (pulled in by Update pgxntool to 2.3.0 (release tag) #31's pgxntool 2.3.0 update) now contains its own installcheck: install prerequisite, with a comment explaining the same ordering issue (PGXS's installcheck not depending on install, causing test's unordered TEST_DEPS to run them out of order).
• The local copy removed in this PR (Makefile:8-13 on origin/master) was textually identical in effect (installcheck: install), so it was purely redundant — Make just accumulates prerequisites across duplicate rule stanzas, so having it twice was harmless but added nothing.
• Confirmed no other copy of this rule remains in the repo (grep -rn "installcheck: install" --include=Makefile . only matches inside pgxntool/).
• The diff is a clean 7-line removal with nothing else touched — matches the PR description exactly.
• CI on this PR (run 31424369970) passed.

No issues found. This is a safe, well-justified cleanup.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fa6b06fd-f528-45b9-8653-0c7772cc6bef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}