Bump .vendor/linter: tighten comment-stacked-dashes to 2+ lines

[jnasbyupgrade]

Summary

• Bumps the .vendor/linter submodule to pick up Postgres-Extensions/linter#9: comment-stacked-dashes now flags 2+ consecutive -- lines (previously 3+); only a single -- line is allowed before a /* */ block is required.
• The tighter rule flagged existing 2-line -- comments in this repo; converted those to /* */ blocks in a follow-up commit. Pure formatting change — no code semantics altered, and any sql-lint:disable-block directives among them keep working (suppression matching is against raw line text, not comment state).

Test plan

• make lint passes cleanly with the bumped submodule and the comment fixes

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d74bea94-0747-459d-a59b-2fc29e6e818b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Claude finished @jnasbyupgrade's task in 3m 4s —— View job

---

Review: Bump .vendor/linter — tighten comment-stacked-dashes to 2+ lines

• Gather context (diff, changed files, CLAUDE.md conventions)
• Understand the request (code review of PR Bump .vendor/linter: tighten comment-stacked-dashes to 2+ lines #36)
• Review .vendor/linter submodule bump
• Review comment-format conversions in SQL files
• Post final review

Summary: This is a clean, purely mechanical formatting PR with no semantic changes. I reviewed all 3 commits and the full diff against origin/master.

What I checked:

• Submodule bump (596ca61): .vendor/linter moves from b40aaf7 → e4fab69 to pick up the tightened comment-stacked-dashes rule (Tighten comment-stacked-dashes: flag 2+ lines, not just 3+ linter#9). Simple pointer bump, nothing to flag.
• Comment conversions (c52bce9): All converted -- blocks → /* ... */ are mechanically correct — content, indentation, and continuation-line style (\* -prefixed) match the existing /* */ conventions already used elsewhere in sql/object_reference.sql (e.g. lines 39, 320, 428). No text was altered.
• sql-lint:disable-block directive in test/helpers/object_table.sql — the PR body claims suppression matching works against raw line text regardless of comment style, so moving the directive into a /* */ block doesn't break it. I confirmed this is true: CI (31644700540) is green, meaning make lint still passes cleanly with prefer-short-type correctly suppressed for the COPY payload below it.
• Follow-up cleanup (dd16ab8): Rather than reformatting all flagged comments into /* */, this commit deletes the ones that were dead debug scaffolding (commented-out WHEN clauses on the event triggers in sql/object_reference.sql, a stale SET client_min_messages/\i finish.sql pair in test/dump/load_all.sql, and leftover sed/edit notes in test/sql/event_trigger.sql) instead of preserving them as formatted comments. Reasonable judgment call — these were transient scratch notes, not documentation.

Minor, non-blocking observation:

• The three deleted -- For debugging / --WHEN tag IN (...) lines in sql/object_reference.sql did double as a quick toggle a future contributor could uncomment to scope event-trigger firing while debugging (e.g. limit to ALTER TABLE/DROP TABLE). Deleting them removes that scaffolding along with the noise. Not a problem, just flagging in case that toggle was intentionally kept around for convenience — easy to restore from git history if ever needed.

No bugs, security issues, or regressions found. The change does exactly what it says: tightens the vendored lint rule and brings the repo's comments into compliance without altering behavior.