Bump .vendor/linter: tighten comment-stacked-dashes to 2+ lines - #43
Merged
Conversation
Postgres-Extensions/linter#9 tightens comment-stacked-dashes to flag 2+ consecutive -- lines (previously 3+). Bumps 97c89b92 -> e4fab69e.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The bumped linter now flags 2+ consecutive -- lines (previously 3+). Rewriting the existing offenders as /* */ blocks is a pure formatting change; disable-block directives keep working since suppression is matched against raw line text regardless of comment state.
jnasbyupgrade
added a commit
to jnasbyupgrade/test_factory
that referenced
this pull request
Aug 12, 2026
Master's own Postgres-Extensions#43 further tightened the vendored linter's comment-stacked-dashes rule (2+ consecutive "--" lines now must be a block comment, down from 3+), which itself was needed to fix two pre-existing 2-line comments elsewhere. That change conflicted with this branch's own restructured test/install/load.sql, which had duplicated a similar 2-line comment into two places (fresh mode's own "Captured before..." note, and its "Everything from here on..." note) -- both now also need to be block comments under the new threshold. Fixed all three occurrences the linter flagged after resolving. Also caught and fixed my own mistake while resolving this: initially checked out the *previous* .vendor/linter submodule commit instead of the new one master's Postgres-Extensions#43 actually points at (misread the diff direction) -- confirmed against the real upstream linter repo's history before fixing it, which is what actually surfaced these findings in the first place. Verified locally on PG12 and PG17: fresh and update modes both pass, make lint is clean, and sql/test_factory--0.5.0.sql remains untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vendor/lintersubmodule to pick up Postgres-Extensions/linter#9:comment-stacked-dashesnow flags 2+ consecutive--lines (previously 3+); only a single--line is allowed before a/* */block is required.--comments in this repo; converted those to/* */blocks in a follow-up commit. Pure formatting change — no code semantics altered, and anysql-lint:disable-blockdirectives among them keep working (suppression matching is against raw line text, not comment state).Test plan
make lintpasses cleanly with the bumped submodule and the comment fixes