[GrantFox] Stabilize public error mapping (#1380) - #1439
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1380.
Stabilizes public error mapping across all contract variants, ensures non-colliding client code allocations, safe decoding for unknown error codes, and adds comprehensive golden vector integration test coverage.
Acceptance Criteria Checklist
enum Errorvariants (16 new variants) have been assigned unique, non-colliding client codes in their respective domain bands and fully documented.Error::decode_contract_codeandError::decode_client_codesafely decode unknown/out-of-range integer values toPublicErrorMappingwithis_known: falseand fallback defaults ("UNKNOWN_ERROR").test_golden_vectorsinerror_code_tests.rsprovides explicit coverage across Authentication, Market Lifecycle, Betting/Financial, Validation, Circuit Breaker, and Dispute resolution entrypoints.Changes Included
contracts/predictify-hybrid/src/err.rs:PublicErrorMappingmetadata structure.public_mapping(&self),from_contract_code,from_client_code,from_code_str,decode_contract_code, anddecode_client_codefunctions covering all 132Errorvariants.contracts/predictify-hybrid/src/error_code_tests.rs:contracts/predictify-hybrid/src/lib.rs:mod error_code_tests;for test builds.types.rs: AddedEq, PartialEqtoBetStats.admin.rs&validation.rs: FixedConfigValidatorandOracleConfigValidatorcalls.event_topic_compat_tests.rs: Addeduse alloc::format;.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC