feat(notifications): add deterministic notification preference handling (#885) - #931
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
feat(notifications): add deterministic notification preference handling (#885)#931s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
|
@s6pa1rta3n-lab is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #885
Summary
Implements deterministic notification preference handling with strict account isolation, explicit defaults, offline mutation queueing, and conflict reconciliation.
Acceptance Criteria
account: string), preventing cross-contamination when users switch wallets.settlement,market,wallet,dispute,payout,system,account) and delivery channels (inApp,email,push).Architecture & Implementation
types/notification-preferences.ts): Granular types for category toggles, channel toggles, intensity presets, offline mutation records, and reconciliation payloads.lib/notification-preferences.ts): Immutable explicit defaults, account normalization, defensive deserialization, offline mutation applying, deterministic reconciliation (reconcilePreferences), and decision evaluation (shouldDeliverNotification).app/state/notificationPreferences.ts): Zustand store withpersistmiddleware, cross-tab synchronization via storage event listener, and online/offline event listeners.hooks/useNotificationPreferences.ts): Auto-synchronizes withWalletContextaddress changes and exposes helper methods to components.app/(dashboard)/settings/page.tsx): Updated settings page to display account-scoped notification preferences, category/channel controls, intensity presets, and one-click "Reset to defaults".Security and Failure-Mode Considerations
Verification & Tests
lib/__tests__/notification-preferences.test.ts: 100% passing tests for normalization, defaults, offline queueing, conflict resolution, and filtering.app/state/__tests__/notificationPreferences.test.ts: 100% passing tests for account switching, explicit defaults, reset, offline queueing, and persistence.hooks/__tests__/useNotificationPreferences.test.tsx: 100% passing tests for React hook integration and dynamic wallet account switching.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC