Conversation
Chat template parsing previously choked on malformed UTF-8 input. Add common_utf8_sanitize(), which substitutes each maximal invalid subpart with a single U+FFFD per the Unicode recommendation, and retry the chat parse on the sanitized input when recovery happens. Add regression tests (test-chat).
Author
|
Rebased cleanly onto the current |
renovys
force-pushed
the
pr-utf8-ufffd-fix
branch
from
September 30, 2026 02:33
482e11f to
ca2f9fa
Compare
Author
|
Rebased onto the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Chat template parsing hard-fails when the input contains malformed UTF-8 (e.g. truncated multibyte sequences from upstream tooling or IPC boundaries). The whole parse is rejected even though the rest of the input is usable.
Change
Tests
Validation
Running in production on a BC-250 (gfx1013, Vulkan) service for ~7h with mixed Korean/security/code workloads — no template parse failures, no template parse failures and no regressions observed.