docs: clarify AWS Marketplace version - #828
Conversation
Signed-off-by: Kelvin Uneze <kelvinuneze@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Creativeklvn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe AWS installation guide now identifies version ChangesAWS installation documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to The localized documentation change clarifies the AWS Marketplace version, but the corresponding Chinese documentation update or explanation is still incomplete, which could leave users with inconsistent installation guidance until addressed. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| --- | ||
|
|
||
| HAMi is now available on the AWS Marketplace, and you can quickly install it via Helm or AWS add-on. | ||
| HAMi is now available on the AWS Marketplace and can be installed via Helm or the AWS add-on. The installation below uses version 2.6.1-community; for the latest available version, check the [AWS Marketplace listing](https://aws.amazon.com/marketplace/pp/prodview-x237accxbpuwa). |
There was a problem hiding this comment.
the helm command below still pins --version 2.6.1-community. a reader who checks the marketplace for a newer version has no way to use it here. should the command say that too?
| HAMi is now available on the AWS Marketplace, and you can quickly install it via Helm or AWS add-on. | ||
| HAMi is now available on the AWS Marketplace and can be installed via Helm or the AWS add-on. The installation below uses version 2.6.1-community; for the latest available version, check the [AWS Marketplace listing](https://aws.amazon.com/marketplace/pp/prodview-x237accxbpuwa). | ||
|
|
||
| ## Prerequisites |
There was a problem hiding this comment.
this page has translated: true and a zh mirror under i18n/zh, which this pr does not touch. should the version note go there too?
| --- | ||
|
|
||
| HAMi is now available on the AWS Marketplace, and you can quickly install it via Helm or AWS add-on. | ||
| HAMi is now available on the AWS Marketplace and can be installed via Helm or the AWS add-on. The installation below uses version 2.6.1-community; for the latest available version, check the [AWS Marketplace listing](https://aws.amazon.com/marketplace/pp/prodview-x237accxbpuwa). |
There was a problem hiding this comment.
one more here: the Install with AWS Add-on section below carries no version at all, so the installation below wording covers a path this does not apply to. should the note sit under the helm heading instead?
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarifies the AWS Marketplace version used in the installation instructions.
2.6.1-community.Which issue(s) this PR fixes:
Fixes #827
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)Summary by CodeRabbit
2.6.1-communityversion and linked to the AWS Marketplace listing for the latest release.