feat(tools): measure Prometheus ingest cost from a skip_querying run - #550
Merged
milindsrivastava1997 merged 2 commits intoAug 20, 2026
Merged
Conversation
Add --ingest_only_experiment_name to compare_costs.py so the baseline mode's Query CPU can subtract a directly-measured ingest baseline (median Prometheus CPU% from a skip_querying, no-queries-executed run) instead of the 5th-percentile-of-this-run heuristic. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…t heuristic Print a stderr warning when --ingest_only_experiment_name isn't given and compare_costs.py falls back to the 5th-percentile-of-this-run heuristic for Prometheus ingest cost, so it's obvious the Query CPU numbers are a guess rather than a measured baseline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
milindsrivastava1997
deleted the
feat/compare-costs-ingest-only-baseline
branch
August 20, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare_costs.py's baseline (Prometheus) Query CPU was computed by subtracting the 5th percentile of the same run's CPU series as a proxy for ingest cost — an arbitrary heuristic.--ingest_only_experiment_name: point it at askip_querying(ingest-only, no queries executed) experiment run, and the baseline mode's Query CPU instead subtracts the median Prometheus CPU% directly measured from that run.