feat(tools): thread sketch_parameters, rsync init_sql_file, add clickhouse_image_tag - #553
Merged
Merged
Conversation
…house_image_tag - Pass optional sketch_parameters through from experiment config into the generated SQL planner input YAML. - Rsync init_sql_file to the remote node before executing it, instead of assuming it's already present there. - Allow overriding the ClickHouse image tag via dataset.clickhouse_image_tag (pre-AVX2 CPUs SIGILL on "latest"). Split out of #514. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sketch_parametersthrough from experiment config into the generated SQL planner input YAML.init_sql_fileto the remote node before executing it, instead of assuming it's already present there.dataset.clickhouse_image_tag(pre-AVX2 CPUs, e.g. Sandy/Ivy Bridge CloudLab nodes, SIGILL onlatest).Split out of #514, which mixed this with an unrelated
TZ=UTCfix. That's in #552.🤖 Generated with Claude Code