refactor(query-engine): dedup range-context arithmetic between usual and binary-expr range paths - #579
Merged
Conversation
…and binary-expr range paths Extracts the lookback/step calc, extended_store_plan mutation, and RangeQueryExecutionContext construction shared by build_arm_range_context and build_range_query_execution_context_from_parsed into one finish_range_context helper. Closes #578 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_arm_range_context and build_range_query_execution_context_from_parsed computed the lookback/step/extended-store-plan arithmetic identically, copy-pasted. Extracted into one finish_range_context helper so a future fix only has to be made once.
Closes #578