fix(query-engine): skip orphaned dual-population groups in instant queries instead of failing - #602
Merged
Conversation
…eries instead of failing collect_results_separate_keys hard-failed the entire instant query whenever a keys-side group had no matching entry in merged_values, diverging from the range path's #583 fix which skips the orphaned group with a warning instead. Bring instant in line with range (#597). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #597. Instant queries and range queries handled the same edge case differently: a "dual-population" group (separate key/value aggregations) that has key data but no value data anywhere.
Before: instant query hard-fails the whole query.
If
region=orphanhas keys but no values, the entire query errors out —region=normal's perfectly good results disappear too.After: instant query skips just the orphaned group (with a
warn!log) and returns the rest.This matches how range queries already behave (fixed in #583) — a hard-fail was disproportionate for one missing group, and now both query types agree.
Test plan
instant_query_dual_population_group_with_no_value_data_is_skipped_not_fatal, mirroring the existing range-path regression testquery_engine_rusttest suite passes (568 tests)cargo clippyclean🤖 Generated with Claude Code