Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Not needed. |
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/evaluationsto include judge cost.judge?: EvalCostEntryfield inEvalCost(app/lib/types/evaluation.ts).EvalRunCard(app/components/evaluations/EvalRunCard.tsx) whenjob.cost.judgeexists.Checklist
Before submitting a pull request, please ensure that you mark these task.
npm run devandnpm run buildin the repository root and test.Original PR description
Summary
The cost tooltip on
/evaluationsonly listed Response generation cost, omitting thejudgecost entry returned by the backend. This made the tooltip breakdown not add up to the displayedtotal_cost_usdwhenever a run included judge scoring.Changes
EvalCost(app/lib/types/evaluation.ts) now includes an optionaljudge?: EvalCostEntryfield alongsideresponseandembedding.EvalRunCard(app/components/evaluations/EvalRunCard.tsx) renders a Judge scoring row in the cost tooltip whenjob.cost.judgeis present, positioned between the existing "Response generation" and "Cosine similarity calculation" rows to match the backend's cost breakdown order.Why
Response, judge, and embedding costs together make up
total_cost_usd. Without the judge entry, users saw a total that didn't match the sum of the visible line items, causing confusion.Closes #258