refactor(evaluations): Remove run mode state - #277
Open
kaapi-agent-bot[bot] wants to merge 1 commit into
Open
kaapi-agent-bot[bot] wants to merge 1 commit into
kaapi-agent-bot[bot] wants to merge 1 commit into
Conversation
v2 evaluation runs are always fast and capped at 500 items, so the Batch/Fast choice in the run form no longer applies. The picker, its state, and related props are removed; the dataset size warning and error copy are reworded to drop mode-switching language. Closes #267 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #267
Summary
RunEvaluationForm.runMode/setRunModestate and prop threading throughEvaluationsTaband/evaluationspage.run_modefield.Checklist
Before submitting a pull request, please ensure that you mark these task.
npm run devandnpm run buildin the repository root and test.Original PR description
Summary
RunEvaluationFormlet users pick Batch vs. Fast run mode, but v2 evaluation runs are always fast and capped at 500 items (100 original items × 5 duplication factor), so the choice is no longer meaningful.RunEvaluationForm.runMode/setRunModestate and prop threading throughEvaluationsTaband the/evaluationspage.run_modefield.eligible_for_fast === falsedisables the Run button) but reworded the warning/error copy to drop "switch to Batch" language, since Batch is no longer offered.RunMode,EvalJob.run_mode, andRunModeBadgeuntouched — they're still used to display the mode of existing/historical evaluation runs (EvalRunCard,/evaluations/[id]), which is unrelated to this issue.Assumptions
dataset_id'seligible_for_fastflag returned by the backend is still meaningful as a general "too large to run" signal even though the mode picker is gone; I kept using it to gate the Run button and to show a size-limit warning, just without mode-specific wording.run_modefield at all now that fast is the only mode; I removed it from the POST payload rather than hardcoding"fast". Please confirm the backend either ignores a missingrun_modeor defaults to fast — happy to sendrun_mode: "fast"explicitly if that's safer.Test plan
npm run lintpasses (only pre-existing warnings elsewhere)npm run buildpassesCloses #267
🤖 Generated with Claude Code