Skip to content

feat(run-evaluation): Add optional duplication factor input - #278

Open
kaapi-agent-bot[bot] wants to merge 1 commit into
mainfrom
agent/ui-fix-268
Open

kaapi-agent-bot[bot] wants to merge 1 commit into
mainfrom
agent/ui-fix-268

Conversation

@kaapi-agent-bot

@kaapi-agent-bot kaapi-agent-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

Issue

Closes #268

Summary

  • Adds an optional "Duplication Factor" input to RunEvaluationForm.
    • Shown once a dataset is selected, defaulting to that dataset's stored duplication_factor.
  • The run-creation payload in app/(main)/evaluations/page.tsx includes duplication_factor only when the user's value differs from the dataset's stored value.
  • Client-side validation rejects non-integer / less-than-1 values before submission, with a toast error.
  • The override resets to the dataset's stored value when the selected dataset changes and clears after a successful run.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran npm run dev and npm run build in the repository root and test.
  • If you've fixed a bug or added code that is tested
Original PR description

Summary

  • Adds an optional "Duplication Factor" input to RunEvaluationForm, shown once a dataset is selected and defaulting to that dataset's stored duplication_factor.
  • The run-creation payload built in app/(main)/evaluations/page.tsx only includes duplication_factor when the user's value differs from the dataset's stored value, mirroring the existing run_mode pattern (only sent when non-default).
  • Client-side validation rejects non-integer / less-than-1 values before submit, with a toast error, consistent with the other pre-submit checks in handleRunEvaluation.
  • The override resets to the dataset's stored value whenever the selected dataset changes, and clears after a successful run.

Assumptions

  • The backend "v2 run" endpoint referenced in the issue is the existing POST /api/v1/evaluations proxy (app/api/evaluations/route.ts) — there's no separate /v2 route in this repo, so I extended the existing run-creation payload with an optional duplication_factor: number field, following the same "send only when overridden" convention already used for run_mode.
  • "Integer ≥ 1" validation is enforced client-side with a regex (/^[1-9]\d*$/) plus a toast error; no dedicated inline field-error UI was added since the rest of this form uses toast errors for this kind of client-side validation.

Closes #268

🤖 Generated with Claude Code

Lets users override a dataset's stored duplication_factor per run,
defaulting to the dataset's value and only sending duplication_factor
in the run creation payload when the user changes it.
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ready-for-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1937cc94-ebcb-47a4-8526-6f95a700534b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix: add duplication factor override to RunEvaluationForm feat(run-evaluation): Add optional duplication factor input Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RunEvaluationForm: Add duplication factor input

0 participants