feat(run-evaluation): Add optional duplication factor input - #278
Open
kaapi-agent-bot[bot] wants to merge 1 commit into
Open
kaapi-agent-bot[bot] wants to merge 1 commit into
kaapi-agent-bot[bot] wants to merge 1 commit into
Conversation
Lets users override a dataset's stored duplication_factor per run, defaulting to the dataset's value and only sending duplication_factor in the run creation payload when the user changes it.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #268
Summary
RunEvaluationForm.duplication_factor.app/(main)/evaluations/page.tsxincludesduplication_factoronly when the user's value differs from the dataset's stored value.Checklist
Before submitting a pull request, please ensure that you mark these task.
npm run devandnpm run buildin the repository root and test.Original PR description
Summary
RunEvaluationForm, shown once a dataset is selected and defaulting to that dataset's storedduplication_factor.app/(main)/evaluations/page.tsxonly includesduplication_factorwhen the user's value differs from the dataset's stored value, mirroring the existingrun_modepattern (only sent when non-default).handleRunEvaluation.Assumptions
POST /api/v1/evaluationsproxy (app/api/evaluations/route.ts) — there's no separate/v2route in this repo, so I extended the existing run-creation payload with an optionalduplication_factor: numberfield, following the same "send only when overridden" convention already used forrun_mode./^[1-9]\d*$/) plus a toast error; no dedicated inline field-error UI was added since the rest of this form uses toast errors for this kind of client-side validation.Closes #268
🤖 Generated with Claude Code