Verify Police Quest 4: Open Season - #697
Open
tomojira wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Police Quest 4 - Open Season (1993) (Sierra On-Line)
Unfortunately I found that this version from the Police Quest Collection didn't work well. There was no standard
INSTALL.EXEfor changing config, and the replacementINSTALL.BATdidn't seem to work properly with a no-CD setup.I decided to change over to this version, verified by Redump: Police Quest IV - Open Season (USA)
Disc also matches with TDC#23 entry: Police Quest- Open Season v1.100.000 (1994)(Sierra On-Line, Inc.) [bin-cue]
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
Main variant: I added instructions for creating
RESOURCE.CFG. It's needed in the DOSZ to provide paths for the no-CD setup.GOG variant: The default
RESOURCE.CFGdoesn't seem to work well. I copied the version from the main variant, so it's necessary to get it from the DOSC or embedded data.Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
A no-CD setup is used with all files installed.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
Yes, a GOG variant was already added. Unfortunately it no longer matches since a GOG update, so I changed it.
Can the game benefit from using embedded data or embedded patches in the datfile?
Both variants: Yes, added embedded data to
RESOURCE.CFG.Can DoDAT build the game from the install media?
Yes.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
Yes.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
Yes, I changed to a no-CD setup by copying more files from the disc and editing paths in
RESOURCE.CFG.Can the game benefit from using CHDtoOGG?
There are no audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Main variant: Unknown if this CD version has copy protection. Nothing appeared at the beginning of the game.
GOG variant: Doesn't have copy protection according to PCGamingWiki.
Is the game running at the correct speed? Is CPU year specified?
Both variants: No CPU setting was specified. I added
cpu_max_year: 1993(it's dynamic).Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Both variants: No, I added WAITMODECHANGE. MT-32 has a much longer WAIT as well.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Main variant: Yes, it already uses "old". The extension was still .dosz, so I updated it to .dosx.
GOG variant: It was missing, so I added it here.
Does the game have General MIDI support?
Yes, I added it.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
It doesn't seem needed here.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Summary of changes
RESOURCE.CFGcpu_max_year: 1993Unmentioned in the checklist: