Skip to content

Verify Leisure Suit Larry 6: Shape Up or Slip Out! - #704

Open
tomojira wants to merge 4 commits into
PureDOS:mainfrom
tomojira:lsl6
Open

Verify Leisure Suit Larry 6: Shape Up or Slip Out!#704
tomojira wants to merge 4 commits into
PureDOS:mainfrom
tomojira:lsl6

Conversation

@tomojira

Copy link
Copy Markdown
Contributor

Verifying Leisure Suit Larry 6 - Shape Up or Slip Out! (1993) (Sierra On-Line)

Checklist

Have adequate installation instructions been provided to match any config files in the DOSZ?
VGA version: I added instructions for reproducing RESOURCE.CFG. It's needed in the DOSZ because the necessary minHunk value won't be added by INSTALL.EXE later.

SVGA version: No minHunk parameter here, but RESOURCE.CFG is still needed in the DOSZ to give paths for a no-CD setup.

Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.

Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.

For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.

Is the entry in the right variant file (i.e. Freeware)?
Yes.

Have digital versions (Steam, GOG) been checked for matching?
No, and I'm unable to add them.

Can the game benefit from using embedded data or embedded patches in the datfile?
Both versions: Yes, I added embedded data to RESOURCE.CFG.

Can DoDAT build the game from the install media?
VGA version: Yes, after removing 2 unnecessary BAT files.

SVGA version: Yes, after removing 1 BAT file.

If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.

Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.

Do the file timestamps match the installation media?
Yes.

Does the DOSZ run standalone?
Yes.

For CD games, can the game be set up to run without a CD mounted?
VGA version: Not applicable.

SVGA version: Yes, a no-CD setup was already used. However, I changed the file list to remove the redundant HIRES folder, except for PATCHES.

Can the game benefit from using CHDtoOGG?
Not applicable.

Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.

Does the DOSC contain problematic data (i.e. copyright issue)?
No.

Does the DOSC have copy protection removed, if possible?
Unknown if this CD version removes copy protection. Nothing appears at the beginning.

Is the game running at the correct speed? Is CPU year specified?
VGA version: No CPU year was specified. I added cpu_year: 1993 since the speed seemed fine and Sierra Help doesn't mention speed bugs.

SVGA version: This one is dynamic, so I used cpu_max_year: 1993. Note that Larry moves much faster in this version by default, but this is just the speed setting in the game and can be changed.

Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
Both versions: Yes. I added a longer WAIT to the MT-32 option.

SVGA version: Also needed a longer WAIT for General MIDI.

Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Both versions: Yes, it's using "old". The extension was still .dosz, so I updated to .dosx.

Does the game have General MIDI support?
Both versions: Yes, but it was missing, I added it.

Is the game set up to run with the best quality graphics options by default?
Not applicable.

For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.

Does the game have a mouse cursor that benefits from enabling input_directmouse?
Both versions: Yes, I enabled it.

Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.

Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.

Summary of changes

  • Both versions: Added RESOURCE.CFG to DOSZ with embedded data
  • Both versions: Removed unneeded files to help DoDAT
  • SVGA version: Mostly removed redundant HIRES folder
  • VGA version: Added cpu_year: 1993
  • SVGA version: Added cpu_max_year: 1993
  • Both versions: Added longer WAIT to MT-32 option
  • SVGA version: Also added longer WAIT for General MIDI
  • Both versions: Updated MT-32 extension to .dosx
  • Both versions: Enabled direct mouse
  • Edited comments and links

Unmentioned in the checklist:

  • The fully voiced SVGA version was titled "CD Version", but the less voiced VGA version was apparently also released on CD, so it could be slightly misleading. I renamed SVGA to the normal base title for the main dat, and moved VGA to the Misc dat as a (VGA Version) variant. This may be more consistent with how games like Freddy Pharkas were added in the past - fully voiced version in main and less voiced in Misc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant