Fix tests against qcodes main while keeping 0.58.0 support - #246
Merged
Conversation
QCoDeS made snapshot timestamps timezone aware and changed the default snapshot `update` to `Only_invalid`, which broke two tests here. * Emit the loop `ts_start`/`ts_end` metadata in the same timezone aware ISO format QCoDeS now uses for parameter snapshots. * Accept both the timezone aware and the older naive timestamp spelling when checking snapshot timestamps, so the tests pass on qcodes 0.58.0 as well. * Prime the cache of the aborting parameter in `test_halt` so that the snapshots taken while setting up the loop are served from the cache and no longer consume the abort counter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jenshnielsen
enabled auto-merge
August 28, 2026 09:22
astafan8
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QCoDeS made snapshot timestamps timezone aware and changed the default snapshot
updatetoOnly_invalid, which broke two tests here.ts_start/ts_endmetadata in the same timezone aware ISO format QCoDeS now uses for parameter snapshots.test_haltso that the snapshots taken while setting up the loop are served from the cache and no longer consume the abort counter.