🌐 [translation-sync] FIX: seven source-side defects in python_by_example, functions, numpy and pandas - #29
Conversation
✅ Translation Quality ReviewVerdict: PASS | Model: claude-sonnet-5 | Date: 2026-08-05 📝 Translation Quality
Summary: The translation of the changed sections is accurate, fluent, and terminologically consistent with the glossary. Minor stylistic issues remain around occasional direct reader address ('vous') that could be rendered more impersonally per the specified academic register, but these do not impede comprehension. No syntax or structural errors were found in the modified sections. Consistent and accurate use of glossary terminology (e.g., 'Loi normale centrée réduite', 'Tirages aléatoires', 'Chaîne de Markov'-style precision maintained elsewhere) Faithful preservation of code blocks, math notation, and MyST directive syntax throughout the changed sections Correct French typography applied (non-breaking spaces before high punctuation, appropriate translation of descriptive symbols like 'aire = π * rayon²') Good restructuring of long English sentences into clearer French ones in the Overview and Random Draws sections Suggestions:
🔍 Diff Quality
Summary: Several source code and prose changes (LIFO/FILO wording, isinstance/pd.isna refactors, df.where argument addition) were not propagated to the target document's code cells and text. Issues:
This review was generated automatically by action-translation review mode. |
There was a problem hiding this comment.
Pull request overview
Synchronise la version française avec le correctif source (PR QuantEcon/lecture-python-programming#604) en appliquant plusieurs ajustements de contenu dans les cours (Python par l’exemple, fonctions, pandas) et en mettant à jour les métadonnées de synchronisation de traduction.
Changes:
- Nettoyage de la mise en forme (suppression de lignes vides parasites, ajustements de ponctuation/inline-code) dans
python_by_example.mdetfunctions.md. - Corrections d’exemples et de formulation dans
pandas.md(notammentwhere(...)et traitement de valeurs manquantes viapd.isna). - Mise à jour des fichiers d’état
.translate/state/*.yml(SHA source, date de sync, modèle, version d’outil).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lectures/python_by_example.md | Ajustements de mise en forme et clarification de l’explication de la boucle while. |
| lectures/pandas.md | Corrections d’exemples (where/NaN, isinstance, pd.isna) et reformulations associées. |
| lectures/functions.md | Nettoyage de mise en forme et correction de terminologie (LIFO). |
| .translate/state/python_by_example.md.yml | Mise à jour des métadonnées de synchronisation de traduction. |
| .translate/state/pandas.md.yml | Mise à jour des métadonnées de synchronisation de traduction. |
| .translate/state/functions.md.yml | Mise à jour des métadonnées de synchronisation de traduction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```{code-cell} python3 | ||
| i == ts_length # la condition de fin de la boucle while | ||
| i == ts_length #la condition de fin de la boucle while |
📖 Netlify Preview Ready!Preview URL: https://pr-29--verdant-toffee-3261a8.netlify.app Commit: 📚 Changed LecturesBuild Info
|
|
Notes from reviewing the zh-cn counterpart of this same sync round (.zh-cn#86, now merged). Three things worth knowing before this one is reviewed.
|
| Upstream item | French status |
|---|---|
space after --- at the np.loadtxt line |
already spaced both sides at numpy.md:240 ✅ |
**Part1** → **Part 1** |
already **Partie 1** / **Partie 2** at :1428 / :1447 ✅ |
Numpy → NumPy |
already correct at :1424 ✅ |
prose discreteRV → DiscreteRV |
still discreteRV at :1292 ❌ |
So one real fix is outstanding, and the state file is stale regardless. The concerning part is not the single missed word — it is that the file was skipped wholesale rather than evaluated and found to be a near-no-op. That is the silent-omission class from QuantEcon/action-translation#222 and #90.
The scope is wider than #604
Unlike the zh-cn counterpart, this is a catch-up sync: pandas.md moves from 02e57a5, and functions.md / python_by_example.md from 1b356ab / 3241a07, all to aacff38. It therefore carries intermediate upstream commits as well as #604 — for example df.where(df.POP >= 20000, False) → df.where(df.POP >= 20000) with its accompanying prose change from "n'importe quelles autres valeurs" to "NaN", which is not part of #604 at all.
Reviewing this against #604's diff alone will read as unexplained scope drift. It should be reviewed against the full commit ranges instead.
One line looks unchanged but is not
In python_by_example.md, the pair around "Pour le moment, retenons simplement que :" renders identically on both sides of the diff. The only difference is at character 130: the + side has U+00A0 where the - side has a plain space, i.e. the non-breaking space before the colon that French typography requires. That is the typography transform working correctly — not diff noise, and worth not "cleaning up".
Minor, in the same file: i == ts_length # la condition de fin → #la condition de fin, which mirrors the English comment's missing space after #.
|
Follow-up with the decisive evidence for the This PR's That is the signature of QuantEcon/action-translation#90's mode 3, where I have written it up in full. The sibling sync of the same source PR into Practical upshot for reviewing this PR: it can be merged on its own merits — the three delivered files are correct — but |
Automated Translation Sync
This PR contains automated translations from QuantEcon/lecture-python-programming.
Source PR
#604 - FIX: seven source-side defects in python_by_example, functions, numpy and pandas
Files Updated
lectures/functions.md.translate/state/functions.md.ymllectures/pandas.md.translate/state/pandas.md.ymllectures/python_by_example.md.translate/state/python_by_example.md.ymlDetails
This PR was created automatically by the translation action.