Some update - #53
Open
dewabisma wants to merge 1 commit into
Open
Conversation
n13
requested changes
Sep 9, 2026
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT 5.6 Sol
Verdict: REQUEST_CHANGES
One blocking operational issue remains:
- [P1] Keep the RPC scrape targets on resolvable hostnames —
prometheus/prometheus.yml:837and:872. All four new targets (rpc1/rpc2×qm/hmunder*-mainnet.quantus.com) currently have no A or AAAA answer from either 1.1.1.1 or 8.8.8.8, and an HTTPS probe fails with curl error 6. In contrast, all four hostnames this patch replaces still resolve and return the expected Cloudflare Access401. Deploying this config now makes bothrpcnode-chainandrpcnode-nodeunable to scrape either RPC node, so the mainnet RPC dashboards and data-based alerts lose their real signal. Please provision and externally verify the four exact DNS/tunnel hostnames before switching monitoring, or retain the resolving targets until that dependency is live.
Validation performed at head 07907dc828a7b1062a4af7b3b47ae41e125a12d3:
promtool v3.14.0 check config prometheus/prometheus.ymlpassed.- All changed JSON and YAML parsed successfully;
git diff --checkpassed. - Prettier passed for every changed Grafana JSON/YAML file. The repository-wide formatter still reports only three unchanged files.
- All 18 new bootnode/RPC metric names were checked in public DNS; the 14 bootnode names resolve, while the four RPC names above do not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.