fix(redis): guard disconnect against null check operator exceptions on uninitialized socket close - #660
Merged
Conversation
- Guard RedisConnection.disconnect() against uninitialized socket close exceptions - Add forceClose() delegating cleanly to disconnect() - Add unit tests for idempotent disconnect and forceClose Closes #657
github-actions
Bot
added
bug
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #657 by guarding
RedisConnection.disconnect()against internal socket null-assertions:Idempotent & Safe Disconnect:
close()calls inRedisConnection.disconnect()andFakeRedisConnection.disconnect().Null check operator used on a null valueexceptions when closing uninitialized or already-closed Redis connections.forceClose()method onRedisConnection.Testing:
forceClose delegates to disconnect cleanlyintest/core/database/redis_connection_test.dart.Closes #657