fix(extensions): harden plugin rpc bridge against stdin flush hangs and manifest request timeouts - #668
Merged
Conversation
…nd manifest request timeouts (close #666)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666
Summary of Changes
_stdin.flush()inJsonRpcStdioClient.sendRequestwith a 3-second timeout and clean request error/removal, preventing permanent UI freezes when OS pipe buffers fill up during child process hangs.SandboxWatchdogdetects a ping timeout (deadlock),PluginRpcBridgenow immediately fails in-flight requests withPluginDeadlockExceptionand disposes local handles without waiting for full RPC request timeout.timeout_secondstoResourceLimits.ExtensionDriverSessionnow passes the manifest-configured timeout (e.g. 600s for ClickHouse) toPluginRpcBridgeinstead of restricting queries to the default 30s.SandboxStderrPipeto the thrownPluginProtocolTimeoutException.onProcessExitedhook toPluginRpcBridgesoExtensionDriverSessionimmediately drops terminated processes from_bridgesupon exit.onProcessExited, handshake timeout stderr output,PluginDeadlockException, andResourceLimitstimeout parsing.