To consider a switch to a maintainted fork of nv-i18n - #24
Open
AlanGraham wants to merge 1 commit into
Open
Conversation
The original nv-i18n is no longer being maintained. Our company app relies on it, and needed newly created entries. A colleague and I have forked and published a new version of it. Due to our reliance on it we will be continuing to maintain it. The fork is available here, and we have published updates to mvnrepository https://github.com/foundationsedge/nv-i18n https://central.sonatype.com/artifact/uk.co.foundationsedge/nv-i18n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The original nv-i18n is no longer being maintained. Our company app relies on it, and needed newly created entries. A colleague and I have forked and published a new version of it. Due to our reliance on it we will be continuing to maintain it.
The fork is available here, and we have published updates to mvnrepository
https://github.com/foundationsedge/nv-i18n
https://central.sonatype.com/artifact/uk.co.foundationsedge/nv-i18n
Changes from
com.neovisionaries:nv-i18n:1.29touk.co.foundationsedge:nv-i18n:1.34.1See below on tests, I couldn't get your project to build to run tests, or in the fork. I couldn't see any reference to specific enum values which may have become deprecated.
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this
library has unit and/or integration testing, tests should be added for new functionality and existing tests should
complete without errors.
I tried building your project to run the tests but got several compiler errors. As I haven't used it before I'm not sure what extra configuration is required.
Checklist
the Reloadly general contribution guidelines
the Reloadly Code of Conduct