Skip to content

DEPENDENTLOADFLAG also for Clang/SYCL; CI - #20

Merged
johguenther merged 3 commits into
masterfrom
guj/devel
Aug 17, 2026
Merged

DEPENDENTLOADFLAG also for Clang/SYCL; CI#20
johguenther merged 3 commits into
masterfrom
guj/devel

Conversation

@johguenther

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates rkcommon’s Windows linker configuration to apply DEPENDENTLOADFLAG when building with Clang-based toolchains (e.g., SYCL/DPC++ via clang++), and adjusts CI coverage accordingly.

Changes:

  • Bump project version to 1.15.3.
  • Extend Windows DEPENDENTLOADFLAG:0x2000 linker-flag handling to the Clang compiler path.
  • Update CI: drop VS2017 jobs on Windows; on Linux update oneAPI version and add a Rocky8 “DPC++/intel-llvm” build + test lane.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
CMakeLists.txt Bumps rkcommon version to 1.15.3.
cmake/rkcommon_macros.cmake Adds Clang-specific Windows linker flags for DEPENDENTLOADFLAG.
.github/workflows/ci.windows.yml Removes MSVC15 (VS2017) build/test jobs.
.github/workflows/ci.linux.yml Updates Intel toolchain version and adds Rocky8 DPC++ build/test jobs.
Suppressed comments (1)

.github/workflows/ci.linux.yml:46

  • The new build-rocky8-dpcpp job relies on implicit compiler selection (no CC/CXX exports and build.sh doesn’t set compilers). To ensure this job actually exercises the intended SYCL/DPC++ toolchain (and doesn’t silently fall back to the container default compiler), it would be safer to explicitly set CC/CXX (or pass -DCMAKE_C_COMPILER / -DCMAKE_CXX_COMPILER to CMake).
      dpcpp-version: intel-llvm/v7.0.0
      cmd: |
        .github/scripts/build.sh

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.linux.yml
@johguenther
johguenther merged commit 45f9cad into master Aug 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants