DEPENDENTLOADFLAG also for Clang/SYCL; CI - #20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates rkcommon’s Windows linker configuration to apply DEPENDENTLOADFLAG when building with Clang-based toolchains (e.g., SYCL/DPC++ via clang++), and adjusts CI coverage accordingly.
Changes:
- Bump project version to
1.15.3. - Extend Windows
DEPENDENTLOADFLAG:0x2000linker-flag handling to the Clang compiler path. - Update CI: drop VS2017 jobs on Windows; on Linux update oneAPI version and add a Rocky8 “DPC++/intel-llvm” build + test lane.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Bumps rkcommon version to 1.15.3. |
| cmake/rkcommon_macros.cmake | Adds Clang-specific Windows linker flags for DEPENDENTLOADFLAG. |
| .github/workflows/ci.windows.yml | Removes MSVC15 (VS2017) build/test jobs. |
| .github/workflows/ci.linux.yml | Updates Intel toolchain version and adds Rocky8 DPC++ build/test jobs. |
Suppressed comments (1)
.github/workflows/ci.linux.yml:46
- The new
build-rocky8-dpcppjob relies on implicit compiler selection (noCC/CXXexports andbuild.shdoesn’t set compilers). To ensure this job actually exercises the intended SYCL/DPC++ toolchain (and doesn’t silently fall back to the container default compiler), it would be safer to explicitly setCC/CXX(or pass-DCMAKE_C_COMPILER/-DCMAKE_CXX_COMPILERto CMake).
dpcpp-version: intel-llvm/v7.0.0
cmd: |
.github/scripts/build.sh
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.