Skip to content

Fix: archived-check shows "unknown" for unreachable repos, not silence #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clickmatos wants to merge 1 commit into from
Closed

Fix: archived-check shows "unknown" for unreachable repos, not silence #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions platform/lib/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,9 @@ export const translations = {
checkingArchived: "Checking...",
hideArchived: "Hide archived",
archivedTag: "archived",
archivedUnknownTag: "unknown",
archivedUnknownHint:
"Couldn't check — likely a private repo your GitHub login can't read",
noGithubLink: "Sign in with GitHub to check archived status",
},
},
Expand Down Expand Up @@ -1885,6 +1888,9 @@ export const translations = {
checkingArchived: "Checando...",
hideArchived: "Ocultar arquivados",
archivedTag: "arquivado",
archivedUnknownTag: "desconhecido",
archivedUnknownHint:
"Não deu pra checar — provavelmente um repo privado que seu login do GitHub não consegue ler",
noGithubLink:
"Faça login com GitHub para checar status de arquivamento",
},
Expand Down
8 changes: 8 additions & 0 deletions platform/src/app/[tenant]/dashboard/repo-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,14 @@ export function RepoList({
{t("dashboard.repoList.archivedTag")}
</span>
)}
{hasCheckedArchived && archived === null && (
<span
title={t("dashboard.repoList.archivedUnknownHint")}
className="flex-shrink-0 font-sans text-[10px] font-normal text-muted-foreground"
>
{t("dashboard.repoList.archivedUnknownTag")}
</span>
)}
</p>
<p className="truncate text-xs text-muted-foreground">
{repo.runs_count} runs
Expand Down
Loading