Remove the archived-repos check/filter from /repos - #199
Merged
Conversation
Decided not to keep this: 945 of 948 RocketBus repos are private (99%), and the check only works for public repos (the session's GitHub OAuth scope has no `repo` grant) — expanding that scope wasn't worth the re-consent/security-surface cost for a feature that would mostly show "unknown" anyway. Removes: - checkArchivedStatus() from lib/github.ts - POST /api/repos/check-archived - the "Check archived"/"Hide archived" buttons, archived badge, and related state in repo-list.tsx - the now-unused archived-* translation keys The stale filter (no push in 90d+) is unaffected — it doesn't depend on any of this, it's a pure client-side filter over data the page already loads. Also un-extracts normalizeRepoSlug back into lib/integrations/datadog/sync.ts (deleting lib/repo-slug.ts) — it was only pulled out because repo-list.tsx importing it dragged sync.ts's server-only module graph into the client bundle; with that import gone, sync.ts is the only remaining consumer again, so the separate module no longer serves a purpose. Co-Authored-By: claude-code_2-1-238_agent <claude-code_2-1-238_agent@iris.invalid>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decided not to keep the archived-check feature added in #196/#197: 945 of 948 RocketBus repos are private (99%), and the check only works for public repos since the session's GitHub OAuth scope has no
repogrant. Expanding that scope (re-consent flow, larger security surface) wasn't worth it for a feature that would mostly show "unknown" for real data. See #198 (now superseded, will close) for the investigation that surfaced this.Removes:
checkArchivedStatus()fromlib/github.tsPOST /api/repos/check-archivedrepo-list.tsxarchived*/*Archived*translation keysUnaffected: the stale filter ("no push in 90d+") — it's a pure client-side filter over data the page already loads, doesn't depend on any of this.
Also un-extracts
normalizeRepoSlugback intolib/integrations/datadog/sync.ts(deletinglib/repo-slug.ts) — it was only pulled into its own module becauserepo-list.tsximporting it draggedsync.ts's server-only dependency chain into the client bundle (the build failure fixed on this same feature earlier). With that import gone,sync.tsis the only consumer again, so the split no longer serves a purpose.Test plan
npx tsc --noEmit— cleannpx eslint— cleannpx vitest run— 269 passed (unchanged;datadog-sync.test.ts'snormalizeRepoSlugcoverage still applies to the un-extracted version)npm run build— compiles successfully, 48 routes (down from 49 —/api/repos/check-archivedgone, as expected)🤖 Generated with Claude Code