fix(platform): bridge Hyper Engineers identity by shared raw email too - #207
Merged
Conversation
Extends the same grouping-time lookup added earlier in this branch (check userMap by name, not just at display time) with one more signal: a name->github mapping learned from ANY entry is now also indexed by that entry's raw commit email, so a later entry with a totally different name but the same actual email (e.g. a nickname, instead of an unresolved handle-as-name) still resolves to the same identity instead of rendering as a separate "unidentified" card for the same real person. Co-Authored-By: claude-code_2-1-238_agent <claude-code_2-1-238_agent@iris.invalid>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #206. That PR fixed Hyper Engineers grouping when a repo's commit author name is literally the person's GitHub handle (checking
userMapby name at grouping time, not just at display time). This extends the same "known mapping learned elsewhere" trick with one more signal: raw commit email.Case this closes: a person is "identified" in one repo (their name there resolves to a github via
nameToGithub/userMap), but in another repo commits under a completely different name (nickname, typo, alternate spelling) with the same actual email — neither name-based lookup catches that second entry, so today it renders as a separate "unidentified" card for the same real person.Fix
computeHyperEngineersnow does a first pass over all hyper-engineer author entries to learnemail -> githubwherever a name-based lookup resolves one, then uses that as an additional (last-resort) signal during the actual grouping pass — same two-tier pattern as the name-based lookup, just keyed by email instead.Doesn't merge genuinely unidentified people who share no name, github, or email signal with anyone — those stay in "Não identificados" as before, by design.
Test plan
platform/tests/org-summary.test.ts: two repos, same email, unrelated names, only one resolves by name — asserts they merge into one identified entrynpx vitest run— full suite passes (276/276)npx tsc --noEmit— cleannpx eslint— clean