fix: Use get_motif_features() for is_motif_atom lookup - #378
Merged
Conversation
Replace direct attribute access on atom_array with get_motif_features() from conditioning_base to retrieve is_motif_atom, making the hbonds_hbplus transform consistent with how motif features are obtained elsewhere.
Replace direct atom_array.is_motif_atom attribute access with get_motif_features() helper in both rfd3na and rfd3 hbonds_hbplus transforms. Also adds the missing import and usage of get_motif_features in rfd3na, which was previously absent.
rclune
force-pushed
the
fix_hbond_metrics
branch
from
August 25, 2026 16:04
efee6a2 to
1c8886f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct attribute access on atom_array with get_motif_features() from conditioning_base to retrieve is_motif_atom, making the hbonds_hbplus transform consistent with how motif features are obtained elsewhere.
AI Disclosure: Claude Sonnet 5 was used to create this PR