Allow browsing-mode users to get the backup Parsons problem - #1372
Merged
bnmnetp merged 2 commits intoAug 14, 2026
Merged
Conversation
Previously /ns/coach/parsons_scaffolding required login unconditionally (Depends(auth_manager)), so logged-out/browsing-mode users got a hard 401 even when the exercise had a pre-authored, non-AI backup Parsons problem configured. Swap in an optional-auth dependency and, for anonymous users, serve the static backup when one exists; otherwise keep requiring login for the CodeTailor/LLM-personalized path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bnmnetp
requested changes
Aug 14, 2026
Member
|
I was just about to start a build of all of the servers to deploy tomorrow morning. I can hold off for a couple of hours if you think you can address my comment today. |
Contributor
Author
|
Yes I can do that in a couple moments, thanks for holding off! |
Per review feedback: relocate the optional-auth dependency out of coach.py and into components/rsptx/auth/session.py (alongside auth_manager) so other endpoints can reuse it, and drop the leading underscore now that it's a public helper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously /ns/coach/parsons_scaffolding required login unconditionally (Depends(auth_manager)), so logged-out/browsing-mode users got a hard 401 even when the exercise had a pre-authored, non-AI backup Parsons problem configured. Swap in an optional-auth dependency and, for anonymous users, serve the static backup when one exists; otherwise keep requiring login for the CodeTailor/LLM-personalized path.